[feat] Modify existing SHA-256 subair to support SHA-512 #1370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpwang
force-pushed
the
develop
branch
from
850f06c to
8ea1e6d
Compare
Avaneesh-axiom
force-pushed
the
feat/sha-512-subair
branch
from
3b9254b to
abcd8b1
Compare
Avaneesh-axiom
force-pushed
the
feat/sha-512-subair
branch
from
abcd8b1 to
485e65f
Compare
Avaneesh-axiom
force-pushed
the
feat/sha-512-subair
branch
from
485e65f to
eee18cd
Compare
|
Closing because I'll update both the subair and vm chip in a single PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI won't pass because the sha vm chip is not updated (that's in #1369) but the tests in
sha-airpasssha-macroscrate that provides derive macros to generate reference-versions of the sha subair columns structs.ShaConfigtrait holds associated constants that determine the sha2 variant (i.e. SHA256 or SHA512).Closes INT-3212